Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of building GUI app for Apple macOS. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gubarev
Copy link

@Gubarev Gubarev commented Jan 31, 2017

  1. Include OpenGL in different way.
  2. Link with OpenGL frameworks rather than libraries.

Public domain: yes

1. Include OpenGL in different way.
2. Link with OpenGL frameworks rather than libraries.
@akavel
Copy link
Owner

akavel commented Jan 31, 2017

Thanks! I understand the original was not building, and now it just builds? or does it require something more?

Are you ok with releasing your modifications to public domain? If yes, can you please write this in the commit message? I need this to be able to safely merge this, I believe. Thanks!

@Gubarev
Copy link
Author

Gubarev commented Jan 31, 2017

now it just builds? or does it require something more?

Just builds :)
My configuration is latest default for development on Mac: macOS Sierra 10.12, Xcode 8.2.1 with command line tools.

Are you ok with releasing your modifications to public domain?

Yes

@akavel
Copy link
Owner

akavel commented Feb 2, 2017

Please write your agreement to make it public domain in the git commit message, not in the github comment, ok? Thanks in advance!

@Gubarev
Copy link
Author

Gubarev commented Feb 2, 2017

How I can do this? As far as I know there is no direct way to edit message of pushed commit. Perhaps only suspicions actions which includes pushing with force.

@akavel
Copy link
Owner

akavel commented Feb 6, 2017

Exactly - you need to locally do git amend, and then git push -f. This is normal way of doing such things, nothing suspicious in it! Or do you have some specific doubts with this? If so, maybe I can try to explain them.

You can also do this in a separate branch if you want - then you can make new commit (for example rebase or cherry-pick, then amend), then push the new branch and make new Pull Request instead of this one. But normally on GitHub you can amend commits (and push -f) to improve them based on review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants