Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to create a dedicated Form class for the Form object #645

Merged
merged 3 commits into from
Jan 31, 2017

Conversation

Skullbock
Copy link

No description provided.

@Skullbock
Copy link
Author

@nikosdion found myself in a situation where this could be useful (i needed to change some form to model binding stuff) so i discovered that it wasn't possible as it is for the Toolbar class.

I tested this locally and it works. I also included the correct test case, to be sure

@Skullbock
Copy link
Author

Mmm this is strange, did i touch something that i shouldn't have @nikosdion @tampe125 ?

@nikosdion
Copy link
Member

I have yet to merge the fixes for the tests required for the new version of PHPunit. I'll have to merge that before we can see if the tests for your code work. Stay tuned.

@Skullbock
Copy link
Author

Skullbock commented Jan 27, 2017 via email

@nikosdion
Copy link
Member

I have adjusted the tests. Can you please fix the merge conflicts so I can marge this?

…ridableFormClass

Conflicts:
	Tests/Factory/BasicFactoryTest.php
@Skullbock
Copy link
Author

@nikosdion should've fixed it ;)

@nikosdion nikosdion merged commit 04c280b into akeeba:development Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants