bump box/spout version to 2.7.2 #5285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmleroux
changed the title
jmleroux
force-pushed
the
jml-bump-spout
branch
2 times, most recently
from
bb559d1
to
10b19b8
Compare
jmleroux
force-pushed
the
jml-bump-spout
branch
from
10b19b8
to
612be1b
Compare
pierallard
approved these changes
Jan 19, 2017
skeleton
suggested changes
Jan 19, 2017
|
@jmleroux What is the status this PR ? |
|
@Arn0d I had no time to run perfbench, so it's kind of suspended. |
|
:D :D :D What exactly to review? Build status? |
a2xchip
approved these changes
May 30, 2017
a2xchip
reviewed
May 30, 2017
CHANGELOG-1.7.md
Outdated
| @@ -6,6 +6,9 @@ | |||
| - PIM-6118: Improve attribute add select to avoid performance impact | |||
| - GITHUB-5716: Redo family mass edit form using backbonejs architecture and internal REST API | |||
|
|
|||
| ## Technical improvements | |||
| - GITHUB-5285: Update to spout 2.7.1 | |||
There was a problem hiding this comment.
To add empty line after ## Technical improvements
jmleroux
changed the title
a2xchip
approved these changes
May 30, 2017
| @@ -12,6 +12,7 @@ | |||
| - TIP-725: Generalization of the refactoring made in the TIP-724 for all screen containing a simple grid | |||
| - TIP-734: Menu and index page is now using the new PEF architecture | |||
| - GITHUB-6174: Show a loading mask during the file upload in the import jobs | |||
| - GITHUB-5285: Upgrade to spout 2.7.2 | |||
|
I close this PR because it was done in 35053fb |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to use last 2.7.2 stable version of box/spout
It fixes some issues with blank lines for example. Usefull for the ExcelInitBundle