-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate java/scala content #23052
Comments
@patriknw I'd be very happy to take this up, could you please explain a little more of what are we planning to do? And what are the areas that we'll be focussing on? |
@atiqsayyed that would be great! The process is as follows:
You could look at https://github.com/akka/akka/pull/23039/files as an example - it's probably best to contribute PR's on a page-per-page basis at least at first. Feel free to let us know if you have any questions/problems! |
Hi just to let you know and to avoid duplicated work, I already started on |
Okay.. Unfortunately i also started with actors :D |
Yep, thanks for coordinating :-) |
I'll work on
to start with and try to do as many as possible... |
For me: |
And I will also tackle two other: |
Sure, recorded @gosubpl's items, as well as @atiqsayyed's PR. |
created pull request for stream-cookbook.md |
hey @richard-imaoka , I'll give it a try to |
OK, marked the items for @atiqsayyed and @naferx |
Raised the above issue in akka-http 😃 |
Now it looks like |
Yes, excellent ;). I couldn't resist trying out what the pages now look like when I remove the page refresh on language switch (6dae337), sneak preview at http://pi.bzzt.net/akka-docs/ . Needs some more careful thinking/work before we can actually put it live, but you can experience how the language switching can now be nice and smooth there :) |
Yep, the new language switch is much smoother. I really like it! 👍 As far as I can tell, remaining tasks are:
https://doc.akka.io/docs/akka/2.4/scala/actors.html Is 1. more for server-side settings which the core team takes care, and 2. might be a trick in JavaScript the community can figure out? |
In fact the redirection can be done in the repo, too - see https://github.com/akka/akka/pull/23544/files#diff-b5f788d092e9bf5e9eb7c8cb3365cf83 . I'll update that PR to resolve merge conflicts today and then perhaps we should just merge it. I suppose we should make a separate ticket for re-introducing the 'suggest the latest version of this page' functionality? Though I think our SEO is now better so people don't end up on older versions of the docs so often anymore ;) |
I added #23869 for the 'latest version' box. I think this one can now be closed! Many thanks to all of you who have been a tremendous help in achieving this! |
With the
@java
and@scala
tags and the multi-tab code snippets it's possible to consolidate java and scala content into same .md file and avoid duplication.Example: https://raw.githubusercontent.com/akka/akka/master/akka-docs/src/main/paradox/scala/guide/tutorial_1.md
Can be done piece-by-piece.
The text was updated successfully, but these errors were encountered: