!act #13490 Changed the callback to SocketOption to accept a channel instead of a Socket, this allows for using the nio features. #15568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the repo owners verify this patch? |
|
Thanks for rebasing! OK TO TEST |
|
PLS BUILD |
|
Pull request validation: SUCCESS 👍 |
|
Thanks for the rebase. Could you squash to one commit? |
|
Squashed. |
| @@ -13,19 +13,38 @@ object Inet { | |||
| */ | |||
| trait SocketOption { | |||
|
|
|||
| def beforeDatagramBind(ds: DatagramSocket): Unit = () | |||
| /** | |||
| * Action to be taken for this option before bind is called() | |||
There was a problem hiding this comment.
Parentheses are on the wrong word. Also same with next two methods.
|
LGTM, after minor nitpicks. |
|
Since this is breaking |
|
Updated migration guide. |
|
LGTM |
1 similar comment
|
LGTM |
|
I just noticed that commit message mentions issue number from assembla. Could you change it to #13490 and then we can merge. |
…nel instead of a Socket, this allows for using the nio features.
For example in Java 7 you can now join a multicast group:
case class JoinGroup(group: InetAddress, networkInterface: NetworkInterface) extends SocketOption {
override def afterConnect(c: DatagramChannel): Unit = {
c.join(group, networkInterface)
}
}
IO(Udp) ! Udp.Bind(self, new InetSocketAddress(MulticastListener.port),
options=List(ReuseAddress(true),
JoinGroup(MulticastListener.group, MulticastListener.interf)))
Other minor changes:
- changed all methods in SocketOption to take a Channel instead of a Socket. The socket can be gotten from the Channel but not the reverse.
- all methods that are called before the bind are now called beforeBind for consistency.
- All network connections now call the beforeBind and afterConnect.
HawaiianSpork
changed the title
2m
added a commit
that referenced
this pull request
Jul 24, 2014
!act #13490 Changed the callback to SocketOption to accept a channel instead of a Socket, this allows for using the nio features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the callback to SocketOption to accept a channel instead of a Socket, this allows for using the nio features.
For example in Java 7 you can now join a multicast group: