Wildcard subscription of ddata changes #31731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Subscribe to keys starting with a given prefix. * Useful together with the new expiry feature, for example. * Also fixed a bug in the (non-released) exiry feature, gossip was broken.
patriknw
commented
Nov 14, 2022
| expiryDuration != Duration.Zero && timestamp <= System.currentTimeMillis() - expiryDuration.toMillis | ||
| } else { | ||
| false | ||
| } |
There was a problem hiding this comment.
This was a bug in the gossip exchange when expiry was configured (enabled) but exchanging other keys without expiry. getExpiryDuration is zero for those.
patriknw
commented
Nov 14, 2022
| } | ||
|
|
||
| enterBarrier("done-7") | ||
| } |
There was a problem hiding this comment.
reproducer of the bug, but also required delta-crdt to be disabled to show up
patriknw
commented
Nov 14, 2022
| val second = role("second") | ||
|
|
||
| commonConfig(ConfigFactory.parseString(""" | ||
| akka.loglevel = DEBUG |
johanandren
approved these changes
Nov 15, 2022
| } | ||
|
|
||
| enterBarrier("done-3") | ||
| } |
There was a problem hiding this comment.
Add two/multiple subscribers with same and or overlapping wildcards, for good measure?
There was a problem hiding this comment.
added a few more in f6675e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
mima