chore: Drop JDK 8 #32127
chore: Drop JDK 8 #32127
Conversation
* remove java 8 home and other complicated things from the build * move src from java-jdk9-only, scala-jdk-9, java-jdk-9
| import org.junit.Test; | ||
| import org.scalatestplus.junit.JUnitSuite; | ||
|
|
||
| public class JavaFlowSupportCompileTest extends JUnitSuite { |
There was a problem hiding this comment.
those JDK reactive streams files were just moved, maybe with some formatting
| } | ||
| def targetJdkJavacOptions(targetSystemJdk: Boolean): Seq[String] = { | ||
| if (targetSystemJdk) Nil | ||
| else Seq("--release", "11") |
There was a problem hiding this comment.
I need to verify that these -release flags work as expected. I know we had problems with them in for example akka/alpakka#2995, but that was for 8
| ## Support for Scala 2.12 removed | ||
|
|
||
| The published artifacts are targeting Scala 2.13 and Scala 3.3. | ||
|
|
There was a problem hiding this comment.
added note in migration guide
|
Seems to work. I tried publishLocal, and checked |
* compile fails with '11' is not a valid choice for '-release', better to fail at startup
|
#32128 |
|
same in re-run, so it has to do with jdk 11 target - maybe we are doing something crazy for real |
Looks like Scala issue: #32128 (comment) |
Draft because I haven't verified everything yet.