Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch: Inverted retry logic #1300

Closed
sergeantwolf opened this issue Oct 31, 2018 · 2 comments · Fixed by #1302
Closed

Elasticsearch: Inverted retry logic #1300

sergeantwolf opened this issue Oct 31, 2018 · 2 comments · Fixed by #1302
Labels
bug p:elasticsearch
Milestone
1.0-M2

Comments

@sergeantwolf
Copy link
Contributor

Currently ElasticsearchFlowStage handleFailure method usage of shouldRetry return value is inverted:
RetryNever retries indefinitely
RetryAtFixedRate fails immediately for any maxRetries values > 0

this line should say

if (!settings.retryLogic.shouldRetry(retryCount, List(exception.toString))) {
@ennru
Copy link
Member

ennru commented Oct 31, 2018

Would you be able to prepare a PR for this?

@ennru ennru changed the title Inverted retry logic Elasticsearch: Inverted retry logic Oct 31, 2018
@sergeantwolf
Copy link
Contributor Author

Sure

sergeantwolf pushed a commit to sergeantwolf/alpakka that referenced this issue Nov 1, 2018
@SergeiFedorov104
Fixes akka#1300 failStage should happen when shouldRetry returns false
ba287f6
@sergeantwolf sergeantwolf mentioned this issue Nov 1, 2018
Merged
ennru pushed a commit that referenced this issue Nov 12, 2018
@sergeantwolf @ennru
Elasticsearch: failStage should happen when shouldRetry returns false (…
e977c48 
…#1302)

Fixes #1300
@ennru ennru added this to the 1.0-M2 milestone Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug p:elasticsearch
Projects
None yet
Milestone
1.0-M2
Development

Successfully merging a pull request may close this issue.

Elasticsearch: failStage should happen when shouldRetry returns false sergeantwolf/alpakka
2 participants
@ennru @sergeantwolf