AWS connectors: align client setup docs #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
dependency-change
|
@gabfssilva @regiskuckaertz could you have a look and check if I got it right? |
LGTM |
| @@ -296,7 +310,7 @@ object Dependencies { | |||
| ExclusionRule("software.amazon.awssdk", "netty-nio-client") | |||
| ), | |||
| "org.mockito" % "mockito-core" % mockitoVersion % Test // MIT | |||
| ) | |||
| ) ++ JacksonDatabindDependencies | |||
|
👍 Looks great! |
seglo
approved these changes
Dec 11, 2019
| import software.amazon.awssdk.auth.credentials.{AwsBasicCredentials, StaticCredentialsProvider} | ||
| import software.amazon.awssdk.services.lambda.LambdaAsyncClient | ||
|
|
||
| val credentials = AwsBasicCredentials.create("x", "x") |
There was a problem hiding this comment.
[minor] I know isn't new code, but maybe we should add a comment link to best practices for AWS key management so users don't just copy and paste this and hardcode credentials. I found this resource: https://docs.aws.amazon.com/general/latest/gr/aws-access-keys-best-practices.html
Co-Authored-By: Sean Glover <sean@seanglover.com>
|
Good point about the credentials, @seglo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Align the docs how the AWS SDK clients are created using Akka HTTP as an underlying HTTP client.
References
References #2014
Changes