Couchbase: add methods for new actors API #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
dependency-change
ennru
force-pushed
the
couchbase-classic-vs-typed
branch
from
ba711af
to
7a3edde
Compare
This was referenced Mar 18, 2020
raboof
approved these changes
Mar 19, 2020
jrudolph
approved these changes
Mar 19, 2020
| */ | ||
| override def get(system: ActorSystem): CouchbaseSessionRegistry = | ||
| super.get(system) | ||
| // This is not source compatible with Akka 2.6 as it lacks `overrride` |
There was a problem hiding this comment.
I think you talked about that. So, that means it will still work on the bytecode level as long as alpakka is compiled against Akka 2.5 but needs changing once Akka 2.5 support is removed?
There was a problem hiding this comment.
Yes. The byte-code-level method signature is unaffected by the override so it works as expected with Akka 2.6.
But compilation with Akka 2.6 fails as the compiler requires the override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement the
CouchbaseSessionRegistryextension with access methods forClassicActorSystemProviderwhich makes it usable without changed for the new actors API'sakka.actor.typed.ActorSystemwithout depending on that module.This can't be compiled against Akka 2.6 as
ExtensionIdin that version contains theapply(ClassicActorSystemProvider)method so it requires anoverridemodifier inCasssandraSessionRegistry.See #2194, #2195