Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest scalafmt #2352

Closed
ignasi35 opened this issue Jul 1, 2020 · 2 comments
Closed

Update to latest scalafmt #2352

ignasi35 opened this issue Jul 1, 2020 · 2 comments
Milestone
invalid/not relea...

Comments

@ignasi35
Copy link
Member

ignasi35 commented Jul 1, 2020

Short description

Bump scalafmt version in .scalafmt.conf.

Details

This version bump may introduce multiple format changes and spark style changes because of new defaults or improvements. We may want to dry-run it first to see the impact since the version bump is high (from 2.1.0 to 2.6.1. as of this writing)
@ignasi35 ignasi35 mentioned this issue Jul 1, 2020
Merged
@jcasadella
Copy link

Hi there! Would like to work on this issue with a friend. We'll send a PR shortly.

jcasadella added a commit to jcasadella/alpakka that referenced this issue Oct 13, 2020
@jcasadella
Update scalafmt and sbt-scalafmt to latest versions akka#2352
51558a3
jcasadella added a commit to jcasadella/alpakka that referenced this issue Oct 13, 2020
@jcasadella
Apply result of sbt scalafmtAll akka#2352
5234858 
Co-authored-by: Sol Lerma <mlermabrines@gmail.com>
jcasadella added a commit to jcasadella/alpakka that referenced this issue Oct 13, 2020
@jcasadella
Update scalafmt and sbt-scalafmt to latest versions akka#2352
70c02d1
jcasadella added a commit to jcasadella/alpakka that referenced this issue Oct 13, 2020
@jcasadella
Apply result of sbt scalafmtAll akka#2352
96ba513 
Co-authored-by: Sol Lerma <mlermabrines@gmail.com>
@jcasadella jcasadella mentioned this issue Oct 13, 2020
Closed
@ignasi35
Copy link
Member Author

We decided we can stay on 2.1.0

@seglo seglo added this to the invalid/not release-bound milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
invalid/not release-bound
Development

No branches or pull requests
3 participants
@ignasi35 @seglo @jcasadella