Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pre-3.0.0 deprecated APIs #2618

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

seglo
Copy link
Member

@seglo seglo commented Mar 15, 2021

I dropped all deprecations. Let's discuss in the PR if any should be restored.

@@ -74,19 +66,6 @@ alpakka.s3 {
}
}

Copy link
Member Author

@seglo seglo Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have gone too far with dropping all the path-style-access/access-path code.

The only reason I can think of not to do this is to support Minio users, but it was found that endpoint-url could be used to satisfy this case #2364.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep these deprecated APIs for now. AWS has decided to support path-style-access indefinitely, so until it's dropped, and there are alternatives for issues like #2620, we should have the option available for users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update (September 23, 2020) – Over the last year, we’ve heard feedback from many customers who have asked us to extend the deprecation date. Based on this feedback we have decided to delay the deprecation of path-style URLs to ensure that customers have the time that they need to transition to virtual hosted-style URLs.

We have also heard feedback from customers that virtual hosted-style URLs should support buckets that have dots in their names for compatibility reasons, so we’re working on developing that support. Once we do, we will provide at least one full year prior to deprecating support for path-style URLs for new buckets.

https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.
LGTM.

@ennru
Copy link
Member

ennru commented Mar 17, 2021

S3 tests are unhappy.

@seglo seglo merged commit 438d34a into akka:master Mar 24, 2021
@seglo seglo deleted the seglo/3.0.0-deprecation-cleanup branch March 24, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants