-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Amazon's Request-signing Test Suite #98
Comments
That would be great indeed, anyone up for jumping on this task? |
Hi, I've started to implement a new test suite using Amazon provided test suite. First problem that I have found with the current implementation is the missing hash of the payload (hash of empty string) in building Canonical Request. In Canonical Request object: See: Task 1: Create a Canonical Request for Signature Version 4 I'll come with PR tomorrow. |
…quest validation.
… Scala test suite refactoring, in prgress.
@joearasin @ktoso implementation is completed. There is only one test that is skipped (you'll see in the code). This is because I did not found a way to build a HttpRequest with body, without having it adding the charset part to content type. If you know a way to do this, then I will update the code in a second. |
I was digging through some of my notes from originally building the S3 functionality and dug this up. Amazon provides a test suite for AWS signature libraries. It might make sense to use it.
http://docs.aws.amazon.com/general/latest/gr/signature-v4-test-suite.html
The text was updated successfully, but these errors were encountered: