Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix Domain Socket: Become 1.0 ready #1168

Merged
merged 3 commits into from
Aug 29, 2018

Conversation

ennru
Copy link
Member

@ennru ennru commented Aug 27, 2018

  • Move internal code to impl; API tests to docs

As part of #1093

@ennru ennru changed the title WIP - Unix Domain Socket: Become 1.0 ready Unix Domain Socket: Become 1.0 ready Aug 28, 2018
@ennru
Copy link
Member Author

ennru commented Aug 28, 2018

@huntc and @longshorej I tried to press this module into our new recommended mould, I hope it makes sense to you.

Copy link
Contributor

@longshorej longshorej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ennru ennru merged commit 71e3467 into akka:master Aug 29, 2018
@ennru ennru added this to the 0.21 milestone Aug 29, 2018
sebastianharko pushed a commit to sebastianharko/alpakka that referenced this pull request Sep 5, 2018
* Move internal code to `impl`
* API tests to docs
dannylesnik pushed a commit to dannylesnik/alpakka that referenced this pull request Sep 8, 2018
* Move internal code to `impl`
* API tests to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants