Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS: Support for durable subscriptions #966 #1178

Merged
merged 1 commit into from
Aug 31, 2018
Merged

JMS: Support for durable subscriptions #966 #1178

merged 1 commit into from
Aug 31, 2018

Conversation

jugalps
Copy link
Contributor

@jugalps jugalps commented Aug 30, 2018 •
edited
Loading

@jugalps jugalps mentioned this pull request Aug 30, 2018
Closed
@lightbend-cla-validator
Copy link

Hi @jugalps,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@ennru ennru added the p:jms label Aug 30, 2018
@jugalps jugalps force-pushed the jugalps-966 branch 2 times, most recently from bb7813c to b67566f Compare August 30, 2018 16:32
@jugalps
Copy link
Contributor Author

jugalps commented Aug 30, 2018

@ennru @liff @russellyou - Let me know if you have any comments on the changes.

@ennru
Copy link
Member

ennru commented Aug 31, 2018

Great that you pick this up. Looks good.
Re-base on the latest changes in master, please.

@jugalps
Copy link
Contributor Author

jugalps commented Aug 31, 2018

@ennru I have rebased the branch from master and the build is successful.

@liff
Copy link

liff commented Aug 31, 2018

LGTM, thanks for picking this up!

ennru
ennru approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ennru ennru merged commit 8f24947 into akka:master Aug 31, 2018
@ennru ennru added this to the 0.21 milestone Aug 31, 2018
@ennru
Copy link
Member

ennru commented Aug 31, 2018

Thank you for your contribution! Keep them coming.

sebastianharko pushed a commit to sebastianharko/alpakka that referenced this pull request Sep 5, 2018
@jugalps
JMS: Support for durable subscriptions (akka#1178)
3b1eb09
dannylesnik pushed a commit to dannylesnik/alpakka that referenced this pull request Sep 8, 2018
@jugalps @dannylesnik
JMS: Support for durable subscriptions (akka#1178)
6d72f21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:jms
Projects
None yet
Milestone
1.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@jugalps @lightbend-cla-validator @ennru @liff