Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Pub/Sub with akka-grpc re-merge #1245

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

2m
Copy link
Member

@2m 2m commented Sep 27, 2018

This is the same as #1162 so we could create a merge commit instead of squash merging.

CremboC and others added 2 commits September 20, 2018 10:54
* test using Google PubSub emulator and client docker containers
@2m 2m added this to the 1.0-M1 milestone Sep 27, 2018
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2m 2m merged commit 2f77203 into akka:master Sep 27, 2018
@2m 2m deleted the wip-akka-grpc-google-pubsub-2m branch September 27, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants