Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SQS: Set proper equality for SQS model #1311

Merged
merged 5 commits into from
Nov 13, 2018
Merged

AWS SQS: Set proper equality for SQS model #1311

merged 5 commits into from
Nov 13, 2018

Conversation

RustedBones
Copy link
Contributor

For review convenience, check diff only on commit
1447d1b

@ennru
Copy link
Member

ennru commented Nov 12, 2018

Thank you for reporting and trying to fix this.
We try to be careful with case classes as they introduce code that is no easily evolved with binary compatibility. I would prefer to make sure we implement equals and hashCode consistently instead.

@ennru ennru mentioned this pull request Nov 12, 2018
Closed
@ennru ennru changed the title AWS SQS: Fixes #1310 - Set proper equality for SQS model AWS SQS: Set proper equality for SQS model Nov 12, 2018
ennru
ennru approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Member

ennru commented Nov 13, 2018

Fixes #1310

@ennru ennru merged commit de0ab9a into akka:master Nov 13, 2018
@ennru ennru added this to the 1.0-M2 milestone Nov 13, 2018
@ennru
Copy link
Member

ennru commented Nov 13, 2018

Thank you for reporting and fixing it!

@RustedBones RustedBones deleted the sqs-model branch November 13, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:aws-sqs
Projects
None yet
Milestone
1.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@RustedBones @ennru