-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMS: towards 1.0 #1314
JMS: towards 1.0 #1314
Conversation
.create(system, queueConnectionFactory) | ||
.withDestination(new CustomDestination(testTopicName, createMqTopic(testTopicName))) | ||
); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #1328 to move these to separate files later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the code a couple of times. I like the documentation split and explanation of settings parameters. Will mirror that in S3 docs as well so it showcases loading settings from conf
files first. LGTM.
ByteStringMessage
(fixes Use ByteString instead of byte[] for JMS bytesSink and bytesSource #701)Fixes #1078