Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMS: towards 1.0 #1314

Merged
merged 27 commits into from
Nov 15, 2018
Merged

JMS: towards 1.0 #1314

merged 27 commits into from
Nov 15, 2018

Conversation

ennru
Copy link
Member

@ennru ennru commented Nov 8, 2018

Fixes #1078

@ennru ennru changed the title WIP - JMS: towards 1.0 JMS: towards 1.0 Nov 14, 2018
.create(system, queueConnectionFactory)
.withDestination(new CustomDestination(testTopicName, createMqTopic(testTopicName)))
);
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #1328 to move these to separate files later.

Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the code a couple of times. I like the documentation split and explanation of settings parameters. Will mirror that in S3 docs as well so it showcases loading settings from conf files first. LGTM.

@ennru ennru merged commit c367b46 into akka:master Nov 15, 2018
@ennru ennru added this to the 1.0-M2 milestone Nov 15, 2018
@ennru ennru deleted the ennru_jms-towards-1.0 branch November 15, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JMS: become Alpakka 1.0 ready Use ByteString instead of byte[] for JMS bytesSink and bytesSource
2 participants