WIP - DO NOT MERGE - Avoid a race condition when creating child actors #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client publications wouldn’t previously withstand a connection being lost when publishing data, whereas server publications would. I’ve now aligned with the client publication handling with the server publication handling as they should be exactly the same.
Session objects can now be told to perform a command directly. The command at this point is just PUBLISH, and the rationale is that the session object is the only thing that can guarantee the QoS requirements of a PUBLISH. Prior to this work, PUBLISH commands were communicated with a command flow, which is often associated with a network connection. The problem with that approach was that PUBLISH commands could be lost if a network connection was lost i.e. the command is consumed, sent via TCP, TCP fails, and the command is lost.
We observed an `InvalidActorNameException` when creating child actors. This could have been due to the following sequence when receiving a “Publish Received Locally” message: 1. prl received, producer actor created 2. producer actor terminates and sends a termination message 3. prl received before termination message is received, the parent actor creates another producer 4. the termination message is received and then attempts to create another producer with the same name The solution is to explicitly track active consumers and producers rather than rely on another data structure such as `context.children`, which will be updated in response to other events.
|
Handled by #1327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #1315 to be merged and then re-basing. For now, review just the last commit.
We observed an
InvalidActorNameExceptionwhen creating child actors under load. This could have been due to the following sequence when receiving a “Publish Received Locally” message:The solution is to explicitly track active consumers and producers rather than rely on another data structure such as
context.children, which will be updated in response to other events.