Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP: Upgrade dependencies #1372

Merged
merged 1 commit into from
Dec 21, 2018
Merged

FTP: Upgrade dependencies #1372

merged 1 commit into from
Dec 21, 2018

Conversation

ennru
Copy link
Member

@ennru ennru commented Dec 13, 2018

Minor API change in the Apache SSHD server used for testing.

@ennru ennru added the p:ftp label Dec 13, 2018
@ennru
Copy link
Member Author

ennru commented Dec 14, 2018

I had hope this upgrade would improve on test failures, but it didn't https://travis-ci.org/akka/alpakka/jobs/467557674#L883

2m
2m approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is still good to upgrade, right? LGTM if so.

@ennru ennru merged commit 6700bfb into akka:master Dec 21, 2018
@ennru ennru deleted the ftp-deps branch December 21, 2018 13:37
@ennru ennru added this to the 1.0-M2 milestone Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
p:ftp
Projects
None yet
Milestone
1.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @2m