Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DynamoDB][#1380] Base URL should be overridable in DynamoClientImpl #1384

Merged
merged 5 commits into from
Dec 19, 2018

Conversation

tPl0ch
Copy link
Contributor

@tPl0ch tPl0ch commented Dec 18, 2018

It is currently impossible to configure the plain HTTP protocol, since the AwsClient trait hard-codes the HTTP protocol scheme.

We need to expose this to the implementations of the AwsClient trait, and in this specific case, the DynamoClientImpl.

  • Did a bit of boy-scouting in AwsClient
  • Converted the private var url to protected def url: String
  • Overrode the url definition in DynamoClientImpl

This PR closes #1380

@tPl0ch
Copy link
Contributor Author

tPl0ch commented Dec 18, 2018

On a second thought though I realized that this might break downstream clients who have set tls to false and are still requesting the HTTPS endpoints.

Releasing this change would mean that all these clients would then start requesting the unencrypted HTTP endpoints.

Should this be reflected in the documentation?

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit e715613 into akka:master Dec 19, 2018
@ennru ennru added this to the 1.0-M2 milestone Dec 19, 2018
@ennru
Copy link
Member

ennru commented Dec 19, 2018

Great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPS protocol in DynamoDB AwsClient should not be hardcoded
2 participants