Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-pub-sub: remove redundant api key #1407

Merged
merged 1 commit into from
Jan 10, 2019
Merged

google-cloud-pub-sub: remove redundant api key #1407

merged 1 commit into from
Jan 10, 2019

Conversation

stephennancekivell
Copy link
Contributor

@stephennancekivell stephennancekivell commented Jan 8, 2019 •
edited
Loading

Fixes issue #832

The usage of the api key was removed in #683

Hopefully we can get this in before 1.0 as it will be a breaking change for the scala/java api.

@stephennancekivell stephennancekivell changed the title remove redundant api key google-cloud-pub-sub: remove redundant api key Jan 8, 2019
ennru
ennru approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit cacc70a into akka:master Jan 10, 2019
@ennru ennru added this to the 1.0-M2 milestone Jan 10, 2019
@ennru
Copy link
Member

ennru commented Jan 10, 2019

Thank you for cleaning this up.

@stephennancekivell
Copy link
Contributor Author

stephennancekivell commented Jan 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
api-change p:google-cloud-pub-sub
Projects
None yet
Milestone
1.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@stephennancekivell @ennru