Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IronMQ towards 1.0 #1472

Merged
merged 13 commits into from
Feb 1, 2019
Merged

IronMQ towards 1.0 #1472

merged 13 commits into from
Feb 1, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Jan 31, 2019 •
edited
Loading

  • Support withXyz for settings
  • Hide internals in impl (including the IronMqClient and Circe codecs)
  • Improve Java API
  • Add examples in the docs
  • Remove Producer and Consumer from factory method names
  • Drop akka.stream prefix from config path

Fixes #1235

@ennru ennru changed the title WIP IronMQ towards 1.0 IronMQ towards 1.0 Jan 31, 2019
2m
2m approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great improvements!

2m
2m approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great improvements!

@2m 2m merged commit 5ed2280 into akka:master Feb 1, 2019
@2m
Copy link
Member

2m commented Feb 1, 2019

Double stamp of approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
api-change p:ironmq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IronMQ: Become Alpakka 1.0 ready
2 participants
@ennru @2m