Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log rotator, compression, sftp example #1476

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Add log rotator, compression, sftp example #1476

merged 3 commits into from
Feb 4, 2019

Conversation

2m
Copy link
Member

@2m 2m commented Feb 1, 2019

Example that uses newly improved Log Rotator sink with compression and sftp.

ennru
ennru approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Possibly add a reference to i in file.md?

@2m
Copy link
Member Author

2m commented Feb 1, 2019

I think you meant the ftp-samples.md. Added it there.

@ennru
Copy link
Member

ennru commented Feb 3, 2019

I think it might make sense to link from the LogRotationSink docs, as well.

@2m 2m mentioned this pull request Feb 4, 2019
Closed
@2m
Copy link
Member Author

2m commented Feb 4, 2019

Roger. Added a link from file connector docs. Also created #1479 to track Java version of this.

@2m 2m merged commit fa78793 into akka:master Feb 4, 2019
@2m 2m deleted the wip-log-compr-sftp-2m branch February 4, 2019 11:29
@2m 2m added this to the 1.0-M3 milestone Feb 4, 2019
@2m 2m added the p:file label Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:file
Projects
None yet
Milestone
1.0-M3
Development

Successfully merging this pull request may close these issues.
2 participants
@2m @ennru