-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMS: IBMMQ update docs #1482
JMS: IBMMQ update docs #1482
Conversation
Looking good. You will also need to modify Line 39 in 472a9b5
|
Hi @2m, build failed on running test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging we need an answer from our colleagues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, always good to run the code the docs show!
Some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for making this happen! |
I am glad to help. |
Pull Request Checklist
Fixes
Compilable docs for IBMMQ and documentation update
Purpose
Background Context
I currently building integration at work and I use
alpakka/jms
connector. I saw differences between versions1.0-M1
and1.0-M2
. Also there is opened issue for doc update.I decided to help. I am looking forward for release
1.0
References
ref: #1328