Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMS: IBMMQ update docs #1482

Merged
merged 7 commits into from
Feb 13, 2019
Merged

JMS: IBMMQ update docs #1482

merged 7 commits into from
Feb 13, 2019

Conversation

zhenik
Copy link
Contributor

@zhenik zhenik commented Feb 6, 2019

Pull Request Checklist

Fixes

Compilable docs for IBMMQ and documentation update

Purpose

  1. Add ibmmq docker image
  2. Add ibmmq clients dependency
  3. Add test classes: scaladsl and javadsl

Background Context

I currently building integration at work and I use alpakka/jms connector. I saw differences between versions 1.0-M1 and 1.0-M2. Also there is opened issue for doc update.
I decided to help. I am looking forward for release 1.0

References

ref: #1328

project/Dependencies.scala Outdated Show resolved Hide resolved
@2m
Copy link
Member

2m commented Feb 7, 2019

Looking good. You will also need to modify .travis.yml to start the ibmmq as well before running tests:

- PRE_CMD="docker-compose up -d amqp"

@zhenik
Copy link
Contributor Author

zhenik commented Feb 7, 2019

Hi @2m, build failed on running test for ftp module, I have not touched it.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging we need an answer from our colleagues.

project/Dependencies.scala Show resolved Hide resolved
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, always good to run the code the docs show!
Some minor comments.

docs/src/main/paradox/jms/ibm-mq.md Outdated Show resolved Hide resolved
docs/src/main/paradox/jms/ibm-mq.md Outdated Show resolved Hide resolved
@ennru ennru added the p:jms label Feb 13, 2019
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Member

ennru commented Feb 13, 2019

Failures were #1492, #1360, #1377

@ennru ennru merged commit 4900ccb into akka:master Feb 13, 2019
@ennru ennru added this to the 1.0-M3 milestone Feb 13, 2019
@ennru
Copy link
Member

ennru commented Feb 13, 2019

Thank you for making this happen!

@zhenik
Copy link
Contributor Author

zhenik commented Feb 13, 2019

I am glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants