Lazy source and flow #1557
Merged
Lazy source and flow #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The origin PR has been merged. This now needs a rebase. |
|
@2m Rebased. |
|
@ennru - I think |
|
Change LGTM. The formatter needs to be ran so Travis is pleased. Also Scala 2.11 needs to be pleased as well where |
The binding and connection flows were not living up to their contract whereupon they should be re-usable. This commit fixes that.
|
I'm unsure what you're referring to re. the formatter... I see that https://travis-ci.org/akka/alpakka/jobs/502859776 failed, but not because of formatting. I've replaced |
|
Sorry, did not into why the formatter job has failed. Thats right, only Scala 2.11 fix needed here. |
|
No probs. 2.11 should now be happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding and connection flows were not living up to their contract whereupon they should be re-usable. This PR fixes that.
The PR has been inspired by the findings of Lunfu Zhong (@zhongl) and his PR: #1552.