Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termination signal handling #1592

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Termination signal handling #1592

merged 1 commit into from
Mar 19, 2019

Conversation

huntc
Copy link
Contributor

@huntc huntc commented Mar 19, 2019

There were a couple of behaviours that were not handling the termination signal where it was possible to receive it. This PR fixes that.

I recommend reviewing without white space changes as the formatter wants to format.

There were a couple of behaviours that were not handling the termination signal where it was possible to receive it. This commit fixes that.
@huntc
Copy link
Contributor Author

huntc commented Mar 19, 2019

An mqtt-streaming test failed, but I doubt anything to do with this change: https://travis-ci.com/akka/alpakka/jobs/185870624. This appears to be more of #1549 (comment).

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit bd737f7 into akka:master Mar 19, 2019
@ennru ennru added this to the 1.0-RC1 milestone Mar 19, 2019
@huntc huntc deleted the termination-signal branch March 20, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants