Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP: up sshj to 0.27.0 #1683

Merged
merged 3 commits into from
Aug 9, 2019
Merged

FTP: up sshj to 0.27.0 #1683

merged 3 commits into from
Aug 9, 2019

Conversation

lewisjkl
Copy link
Contributor

@lewisjkl lewisjkl commented May 7, 2019

Purpose

Several key enhancements were added in version 0.27.0 of sshj. One such feature is adding support for all openssh-key-v1 keyfiles.

Updates the version of the sshj library.

References

https://github.com/hierynomus/sshj/releases

Changes

  • Up version of sshj library to 0.27.0

@lewisjkl lewisjkl marked this pull request as ready for review May 7, 2019 22:07
@ennru ennru added dependency-change For PRs changing the version of a dependency. p:ftp labels May 8, 2019
@ennru
Copy link
Member

ennru commented May 8, 2019

It seems to be better (stricter) with the keys:
"net.schmizz.sshj.transport.TransportException: [HOST_KEY_NOT_VERIFIABLE] Could not verify ssh-ed25519 host key with fingerprint cf:e0:ea:c3:c6:d1:de:a9:bd:0b:a4:0b:7e:f1:4e:3d"

I guess this might fail other people's code as well, so we might need to push this to Alpakka 1.1.0

@ennru ennru changed the title up sshj to 0.27.0 FTP: up sshj to 0.27.0 May 8, 2019
@lewisjkl
Copy link
Contributor Author

lewisjkl commented May 8, 2019

Understood, appreciate you looking at this!

@ennru
Copy link
Member

ennru commented May 9, 2019

Is there a way to make the tests work on Travis?

@ennru ennru added this to the 1.1.0 milestone May 9, 2019
@lewisjkl
Copy link
Contributor Author

lewisjkl commented May 9, 2019

Seems to me like the known_hosts file may need to be updated to include the ssh-ed25519 key in addition to the ssh-rsa key. I will take a look and try that when I get a chance.

@lewisjkl
Copy link
Contributor Author

lewisjkl commented Jun 12, 2019

Looks like the latest build failed because No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. on the stage Code style check (fixed with 'sbt scalafmtAll'). I think this is just a fluke and the CI just needs to be rerun.

@ennru
Copy link
Member

ennru commented Jun 13, 2019

Restarted the build.

@lewisjkl
Copy link
Contributor Author

Thank you for restarting that! It seems like the tests that failed are not related to any changes that I made in this branch. Does it seem that way to you as well?

@ennru
Copy link
Member

ennru commented Jun 13, 2019

Yes, this looks alright. There are a few flaky tests.

@ennru
Copy link
Member

ennru commented Jun 28, 2019

Failures were
#1649
and
#1306

@ennru ennru modified the milestones: 1.1.0, 2.0.0 Jun 28, 2019
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit b0ee1a6 into akka:master Aug 9, 2019
@ennru
Copy link
Member

ennru commented Aug 9, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:ftp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants