AWS S3: use a single date/time for signing #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thadeusb
reviewed
May 20, 2019
| SigningKey( | ||
| requestDate, | ||
| settings.credentialsProvider, | ||
| CredentialScope(requestDate.toLocalDate, settings.s3RegionProvider.getRegion, "s3") |
There was a problem hiding this comment.
I'm wondering, does going back to localDate in the CredentialScope screw things up? Because now requestDate and CredentialScope.date are going to have different dates, causing S3 to reject the request still.
There was a problem hiding this comment.
I do not see how the dates can be different.
From toLocalDate Javadoc: "This returns a LocalDate with the same year, month and day as this date-time."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During AWS request signing the request timestamp and the date in the signed authorization credential should denote the same date, so they should be constructed from a single timestamp.
References
This is a follow-up to #1678
Changes
ZonedDateTimetoSigningKeyCredentialScopefrom the request date inSigningKeyprocessCheckIfExistsResponse