Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3: Move FailedUpload exception to the user facing API #1734

Merged
merged 1 commit into from
May 28, 2019
Merged

S3: Move FailedUpload exception to the user facing API #1734

merged 1 commit into from
May 28, 2019

Conversation

2m
Copy link
Member

@2m 2m commented May 28, 2019 •
edited
Loading

Purpose

Moves FailedUpload exception to the user facing API

References

Fixes #1706

Changes

  • makes the FailedUpload exception public
  • adds a test that mocks a failure after the initial request succeeds

@2m 2m added this to the 1.0.2 milestone May 28, 2019
@ennru ennru changed the title Move FailedUpload exception to the user facing API S3: Move FailedUpload exception to the user facing API May 28, 2019
@ennru ennru added the p:aws-s3 label May 28, 2019
ennru
ennru approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit cab2681 into akka:master May 28, 2019
cheleb pushed a commit to cheleb/alpakka that referenced this pull request Jul 5, 2019
@2m
S3: Move FailedUpload exception to the user facing API (akka#1734)
4b3abf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:aws-s3
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

No longer able to catch alpakka s3 exceptions.
2 participants
@2m @ennru