-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated google pubsub grpc deps to latest version #1781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but since the data classes have changes, this will have to wait until Alpakka 1.1.0.
When is Alpakka 1.1.0 planned to be released? |
Following #1788 (comment) I think this build should pass if we re-run it. Is there a nice way of re-triggering a build or do I have to push a new commit? |
I retriggered it now. |
Thanks @ennru, I noticed you moved the milestone to |
We just decided to rename the upcoming releases. 1.1.0 next week as we add two new connectors. |
Cool, thanks for the clarification, I'll keep an eye on the PR and try to keep it as up to date as I manage. |
Thank you for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you! Great that you engaged to fix it. |
Hi @ennru this is great! Any ETA for the next release that will include this fix? |
We hope to get it together by end of September 2019. |
Hi @ennru, we are keen to start adopting Alpakka 2.0.0 with the updated PubSub libraries. Thanks in advance for your feedback. P.S. I believe the stable 1.1.x. branch, sooner or later, would need this fix. The PubSub libraries included there are going EOL very soon and the GCloud service won't serve them anymore. |
Yes, we couldn't match the pace we aimed for. The plan is to start with Alpakka 2.0 milestone builds during the next weeks. |
Purpose
Updates the versions of the following dependencies so to avoid conflicts with more recent versions of pubsub api.
Background Context
While developing a component that integrates with pubsub we tried using the latest version of it's apis but this caused a conflict with alpakka's version of the pubsub apis which where very obsolete.
For good measure we also updated the other related components which only had minor version changes.