Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated google pubsub grpc deps to latest version #1781

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Updated google pubsub grpc deps to latest version #1781

merged 2 commits into from
Aug 9, 2019

Conversation

DanieleSassoli
Copy link
Contributor

Purpose

Updates the versions of the following dependencies so to avoid conflicts with more recent versions of pubsub api.

"com.google.api.grpc;grpc-google-cloud-pubsub-v1;1.61.0;protobuf", 
"io.grpc;grpc-auth;1.21.0",
"com.google.auth;google-auth-library-oauth2-http;0.16.1"

Background Context

While developing a component that integrates with pubsub we tried using the latest version of it's apis but this caused a conflict with alpakka's version of the pubsub apis which where very obsolete.
For good measure we also updated the other related components which only had minor version changes.

@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. p:google-cloud-pub-sub-grpc labels Jun 26, 2019
@2m 2m added this to the 1.1.0 milestone Jun 27, 2019
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but since the data classes have changes, this will have to wait until Alpakka 1.1.0.

@lucamilanesio
Copy link

The change looks good, but since the data classes have changes, this will have to wait until Alpakka 1.1.0.

When is Alpakka 1.1.0 planned to be released?
Is there any snapshot build available in any public repository in the meantime?

@DanieleSassoli
Copy link
Contributor Author

Following #1788 (comment) I think this build should pass if we re-run it. Is there a nice way of re-triggering a build or do I have to push a new commit?

@ennru
Copy link
Member

ennru commented Jun 28, 2019

I retriggered it now.

@ennru ennru modified the milestones: 1.1.0, 2.0.0 Jun 28, 2019
@DanieleSassoli
Copy link
Contributor Author

Thanks @ennru, I noticed you moved the milestone to 2.0.0, does this mean it won't get released until alpakka 2.0.0 gets released? I don't see any breaking changes. Also this PR will already be obsolete in a couple months time.

@ennru
Copy link
Member

ennru commented Jun 28, 2019

We just decided to rename the upcoming releases. 1.1.0 next week as we add two new connectors.
PRs changing existing APIs or changing dependencies considerably require a major release. We expect to release 2.0.0 in September and will have milestone builds by mid-August.

@DanieleSassoli
Copy link
Contributor Author

Cool, thanks for the clarification, I'll keep an eye on the PR and try to keep it as up to date as I manage.

@ennru
Copy link
Member

ennru commented Jun 28, 2019

Thank you for your patience.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 5a218e6 into akka:master Aug 9, 2019
@ennru
Copy link
Member

ennru commented Aug 9, 2019

Thank you! Great that you engaged to fix it.

@lucamilanesio
Copy link

Hi @ennru this is great! Any ETA for the next release that will include this fix?

@ennru
Copy link
Member

ennru commented Aug 9, 2019

We hope to get it together by end of September 2019.
Once master builds successfully, you may try snapshots https://doc.akka.io/docs/alpakka/snapshot/google-cloud-pub-sub-grpc.html

@DanieleSassoli DanieleSassoli deleted the updateGooglePubSubVersion branch August 20, 2019 14:43
@lucamilanesio
Copy link

We hope to get it together by end of September 2019.

Hi @ennru, we are keen to start adopting Alpakka 2.0.0 with the updated PubSub libraries.
How are things going for the release? You were mentioning September 2019, which was last month.

Thanks in advance for your feedback.

P.S. I believe the stable 1.1.x. branch, sooner or later, would need this fix. The PubSub libraries included there are going EOL very soon and the GCloud service won't serve them anymore.

@ennru
Copy link
Member

ennru commented Oct 18, 2019

Yes, we couldn't match the pace we aimed for. The plan is to start with Alpakka 2.0 milestone builds during the next weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:google-cloud-pub-sub-grpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants