Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS: Java API for JmsMessages withProperties #1904

Merged
merged 1 commit into from
Sep 2, 2019
Merged

JMS: Java API for JmsMessages withProperties #1904

merged 1 commit into from
Sep 2, 2019

Conversation

dotbg
Copy link
Contributor

@dotbg dotbg commented Aug 27, 2019

Implementation for #1900

@ennru ennru changed the title [alpakka-1900] Java API for JmsMessages withProperties JMS: Java API for JmsMessages withProperties Aug 28, 2019
@ennru
Copy link
Member

ennru commented Aug 28, 2019

Thank you for adding this. The compiler is not happy with your use of the Java Hashmap.

@dotbg
Copy link
Contributor Author

dotbg commented Aug 29, 2019

Fixed

@ennru
Copy link
Member

ennru commented Aug 30, 2019

Failure was #1306
https://travis-ci.com/akka/alpakka/jobs/229437607#L1030

ennru
ennru reviewed Aug 30, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick. Looks good otherwise.

jms/src/main/scala/akka/stream/alpakka/jms/JmsMessages.scala Outdated Show resolved Hide resolved
@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. documentation p:file p:ftp p:mqtt labels Aug 30, 2019
@ennru ennru removed dependency-change For PRs changing the version of a dependency. documentation p:file p:ftp p:mqtt labels Sep 2, 2019
ennru
ennru approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 3475506 into akka:master Sep 2, 2019
@ennru
Copy link
Member

ennru commented Sep 2, 2019

Thank you!

@ennru ennru added this to the 2.0.0 milestone Sep 2, 2019
@ennru ennru mentioned this pull request Sep 2, 2019
Closed
ennru pushed a commit to ennru/alpakka that referenced this pull request Oct 9, 2019
@dotbg @ennru
JMS: Java API for JmsMessages withProperties (akka#1904)
cfc261a
@ennru ennru mentioned this pull request Oct 9, 2019
Merged
@ennru
Copy link
Member

ennru commented Oct 9, 2019

Backported to 1.1.2 in #1977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:jms to-be-backported
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@dotbg @ennru