Google Pub/Sub: Fail source when pull status code is not 200 OK #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
force-pushed
the
issue-1902-silent-failure
branch
from
ff2bb0b
to
7d741d6
Compare
LGLO
commented
Sep 10, 2019
| pullResponse <- Unmarshal(response).to[PullResponse] | ||
| pullResponse <- response.status match { | ||
| case StatusCodes.OK => Unmarshal(response).to[PullResponse] | ||
| case status => Future.failed(new RuntimeException(s"Unexpected publish response. Code: [${status}]")) |
There was a problem hiding this comment.
Google PubSub sometimes returns quite nice explanations in body of response.
I was wondering about Unmarshal.to[String] for non OK responses and adding this information to exception message. WDYT?
There was a problem hiding this comment.
Yes, more error context is always a plus.
LGLO
force-pushed
the
issue-1902-silent-failure
branch
from
7d741d6
to
85d5da2
Compare
ennru
reviewed
Sep 11, 2019
| pullResponse <- Unmarshal(response).to[PullResponse] | ||
| pullResponse <- response.status match { | ||
| case StatusCodes.OK => Unmarshal(response).to[PullResponse] | ||
| case status => Future.failed(new RuntimeException(s"Unexpected publish response. Code: [${status}]")) |
There was a problem hiding this comment.
Yes, more error context is always a plus.
ennru
changed the title
Failing ack if response is not success.
LGLO
commented
Sep 11, 2019
| .map { entity => | ||
| throw new RuntimeException(s"Unexpected pull response. Code: [$status]. Entity: [$entity]") | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm using same pattern in pull, acknowledge and publish.
I'm matching for every success status code. If it's not successful, then trying to read error as String to add it to an exception. It works for response with no entity, returning empty string (checked in added spec for acknowledge).
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes behavior for pull subscribe stream.
Before: error responses were successfully Unmarshalled to empty PullResponse, giving no signal that errors occurred.
That was because Google PubSub error response bodies are valid JSON messages and PullResponse contains only one optional field.
After: when status code for pull request is not 200 OK, then source will fail with exception that contain no OK response status.
References
References #1902
Background Context
I've used technique similar to current handling of failed publish requests.