Less use of deprecated APIs in Java code #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests: use Hamcrest's assertThat JMS tests: expect connection to be closed eventually File tests: Check that the file exists, eventually on Travis Slick test: recover -> recoverWithRetries
This was referenced Sep 16, 2020
seglo
approved these changes
Sep 16, 2020
| @@ -5,7 +5,11 @@ | |||
| package akka.stream.alpakka.amqp.javadsl; | |||
|
|
|||
| import static org.hamcrest.CoreMatchers.instanceOf; | |||
| import static org.junit.Assert.*; | |||
| import static org.hamcrest.MatcherAssert.assertThat; | |||
There was a problem hiding this comment.
[question] Why hamcrest's assertThat?
There was a problem hiding this comment.
The JUnit variant is deprecated nowadays.
| @@ -539,7 +539,7 @@ class JmsConnectorsSpec extends JmsSpec { | |||
| val completionFuture: Future[Done] = Source(msgsIn).runWith(jmsSink) | |||
| completionFuture.futureValue shouldBe Done | |||
| // make sure connection was closed | |||
| connectionFactory.cachedConnection shouldBe 'closed | |||
| eventually { connectionFactory.cachedConnection shouldBe Symbol("closed") } | |||
There was a problem hiding this comment.
[minor] Don't like the symbol shorthand?
There was a problem hiding this comment.
That's deprecated in Scala 2.13.
Comment on lines
+71
to
74
| private static ActorSystem setupSystem() { | ||
| final ActorSystem system = ActorSystem.create("MqttFlowTest"); | ||
| final Materializer materializer = ActorMaterializer.create(system); | ||
| return Pair.create(system, materializer); | ||
| return system; | ||
| } |
There was a problem hiding this comment.
[minor] Don't really need this method anymore.
| @@ -194,7 +190,8 @@ lazy val googleCloudPubSubGrpc = alpakkaProject( | |||
| "-P:silencer:pathFilters=akka-grpc/main", | |||
| "-P:silencer:pathFilters=akka-grpc/test" | |||
| ), | |||
| crossScalaVersions --= Seq(Dependencies.Scala211) // 2.11 is not supported since Akka gRPC 0.6 | |||
| compile / javacOptions := (compile / javacOptions).value.filterNot(_ == "-Xlint:deprecation"), | |||
There was a problem hiding this comment.
[minor] This effectively just sets -Xlint:unchecked. We could set this setting to that instead.
There was a problem hiding this comment.
Correct, we might want to add more linting in Common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: use Hamcrest's assertThat
JMS tests: expect connection to be closed eventually
File tests: Check that the file exists, eventually on Travis
Slick test: recover -> recoverWithRetries
A part of #2410