Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: New BigQuery connector #2548
BigQuery: New BigQuery connector #2548
Changes from all commits
496baaf
e35d856
59461f2
716aba4
c72b45b
58f140c
dcd1a77
f0001fc
e78bf25
9c4722f
e069a42
df16ca2
36cd236
5500ccb
7c17772
cc8b55a
c8adcb6
befa0f1
c2dcc14
12870ae
4bced5a
49ea383
6ae4159
cbde365
8d25b24
f9ec80c
47191f1
6223da8
da1ff97
e662063
e6dde8e
442a26b
8b284a8
d5351d2
2df788e
fac5589
530c1ea
eb14b66
d066a7a
f17a65b
96a086b
3ec8c1a
b08e2e2
4340706
1898a29
5155ce4
00d65f2
a561b9c
3024e68
ed71146
f655c4e
88f10ef
f26a2b1
10fcd5d
82c8768
9b4b55e
b66c825
08bc206
09a7b2a
692eab0
ac30537
e9e9247
d6798dd
ce3834b
00e973c
90ff755
e1e2999
6d2b3e8
0a2cffc
146f149
f474acb
5f657c7
5d79786
b8c0c32
a3add92
f52677d
253ddd5
f2c8872
f26ef83
b29a690
08ccbcb
d2c4285
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possile that it is just me, but when I have multiple classes/objects in the same file, I split them to multiple files, or place the "sub"-classes into the "main" object of the file... So I would move the last 3 classes into the
BigQueryAttributes
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just you ;) e.g.
Some
andNone
are not inside ofOption
, same forEither
/Left
/Right
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I just copied the class structure from the other connectors,
S3
IIRC.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm...
https://docs.scala-lang.org/style/files.html says that
class/trait + object
should be in a file, and if you start to introduce adts you should lowercase the filename (likeoption.scala
). No idea when I started to pack every subclass of a sealed trait to the companion object, but I think it started to develop when we tried out tagless final in some projects :D I told you it is nitpicking, I would pack it, you would not, and the scala codestyle says we should lowercase the filename which I would personally never do.I can let it go :P
This file was deleted.