Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Allow bucket creation besides us-east-1 for AWS #2742

Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 4, 2021

There seems to be another inconsistency between real AWS and Minio wrt creating a bucket in the non default region (i.e. us-east-1). With AWS S3 you need an addition XML payload (along with the host/access-style which typically contains the region) in order to create a bucket in a non default us-east-1 region, with Minio this payload is not required. If the XML payload is not in the make bucket request on AWS you will get the following error

The unspecified location constraint is incompatible for the region specific endpoint this request was sent to..

For more details you can read https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html , there is already an existing issue at aws/aws-cli#2603 (comment) which demonstrates the same problem (i.e. even with the aws cli you need to provide an additional LocationConstraint).

A test is provided but do note the fixes on this PR are only verifiable when running the test against AWSS3IntegrationSpec. With MinioS3IntegrationSpec you won't notice any difference.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 3.0.4 milestone Oct 6, 2021
@ennru ennru changed the title Allow bucket creation besides us-east-1 for AWS S3: Allow bucket creation besides us-east-1 for AWS Oct 6, 2021
@ennru ennru merged commit 27fdecf into akka:master Oct 6, 2021
@ennru
Copy link
Member

ennru commented Oct 6, 2021

Thank you for all the great additions and fixes!

@mdedetrich mdedetrich deleted the allow-bucket-creation-non-default-region branch October 6, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants