Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cassandra sink #56

Merged
merged 13 commits into from
Nov 30, 2016
Merged

Cassandra sink #56

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9bc59d4
add simple cassandra sink
stephennancekivell Nov 14, 2016
da6f91d
fix async
stephennancekivell Nov 14, 2016
29314ab
PR feedback.
stephennancekivell Nov 16, 2016
3e5c17c
added java dsl for cassandra sink
stephennancekivell Nov 21, 2016
2af79f8
add cassandra sink docs
stephennancekivell Nov 21, 2016
197ecc2
Merge branch 'master' into cassandra-sink
stephennancekivell Nov 21, 2016
56a1021
apply scalafmt after merge
stephennancekivell Nov 21, 2016
595ed76
pr feedback
stephennancekivell Nov 22, 2016
b4da679
make GuavaFutureOpts private
stephennancekivell Nov 22, 2016
e6fa29d
not a package object.
stephennancekivell Nov 22, 2016
a682466
implicit class, no implicit def.
stephennancekivell Nov 22, 2016
9d80e1f
fix implicit class of same name as object containing it.
stephennancekivell Nov 23, 2016
ac18a87
no change to trigger travis
stephennancekivell Nov 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ka/stream/alpakka/cassandra/package.scala → ...m/alpakka/cassandra/GuavaFutureOpts.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import com.google.common.util.concurrent.{ FutureCallback, Futures, ListenableFu

import scala.concurrent.{ Future, Promise }

package object GuavaFutureOpts {
private[cassandra] final class GuavaFutureOpts[A](val guavaFut: ListenableFuture[A]) extends AnyVal {
private[cassandra] object GuavaFutureOpts {
final class GuavaFutureOpts[A](val guavaFut: ListenableFuture[A]) extends AnyVal {
def asScala(): Future[A] = {
val p = Promise[A]()
val callback = new FutureCallback[A] {
Expand All @@ -20,6 +20,6 @@ package object GuavaFutureOpts {
}
}

private[cassandra] implicit def toGuavaFutureOpts[A](guavaFut: ListenableFuture[A]): GuavaFutureOpts[A] =
implicit def toGuavaFutureOpts[A](guavaFut: ListenableFuture[A]): GuavaFutureOpts[A] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you make the class implicit you do not need this either

new GuavaFutureOpts(guavaFut)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use implicit class ... extends AnyVal instead, like this: https://github.com/akka/akka-persistence-cassandra/blob/master/src/main/scala/akka/persistence/cassandra/package.scala#L22