Removing string.GetHashCode usage from distributed classes #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
approved these changes
Mar 16, 2018
There was a problem hiding this comment.
Thanks @ondrejpialek for picking this up 👍 . Your help here is really appreciated.
This was referenced Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #3361
I have gone through the rest of the distributed / cluster codebase and replaced all
GetHashCodecalls on string instances that I could find.I am raising this as a separate PR because these changes might not be needed. I do not know the codebase very well and in case these are private methods that do not rely on the same bucketing on remote nodes then it is fine to use
GetHashCodeand this PR might potentialy only slow Akka down (assumingGetHashCodeis faster than theMurmurHash).Submitting this for review and let me know if you want me to remove something but keep the rest.