Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sign_xml and to_pdf utility methods #96

Merged
merged 9 commits into from
Apr 9, 2024
Merged

add sign_xml and to_pdf utility methods #96

merged 9 commits into from
Apr 9, 2024

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Apr 1, 2024

adição de helpers:

o diff global talvez não é muito legível. Podem olhar commit por commit ou ver o arquivo final aqui https://github.com/akretion/nfelib/blob/add-sign-and-pdf/nfelib/__init__.py e ver que foi adicionado os helpers to_pdf e sign_xml.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 99.07%. Comparing base (1442dfd) to head (52d55ee).
Report is 2 commits behind head on master.

❗ Current head 52d55ee differs from pull request most recent head fde2006. Consider uploading reports for the commit fde2006 to get more accurate results

Files Patch % Lines
nfelib/__init__.py 68.08% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   98.42%   99.07%   +0.64%     
==========================================
  Files         222      222              
  Lines       10983    11020      +37     
==========================================
+ Hits        10810    10918     +108     
+ Misses        173      102      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvalyi rvalyi changed the title improve CommonMixin code quality add sign_xml and to_pdf utility methods Apr 1, 2024
@rvalyi rvalyi force-pushed the add-sign-and-pdf branch 4 times, most recently from 1f05fa1 to 52d55ee Compare April 1, 2024 02:09
@rvalyi rvalyi merged commit 3098d90 into master Apr 9, 2024
4 checks passed
@github-grap-bot github-grap-bot deleted the add-sign-and-pdf branch April 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants