Skip to content

Commit 32ab00e

Browse files
authored
feat(tooltip, popover): remove ability to use falsy adjustment (#2619)
BREAKING CHANGE: Falsy adjustment values no longer become converted to `NbAdjustment.NOOP`, pass `NbAdjustment.NOOP` instead.
1 parent 0380050 commit 32ab00e

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

src/framework/theme/components/popover/popover.directive.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,6 @@ export class NbPopoverDirective implements NbDynamicOverlayController, OnChanges
154154
return this._adjustment;
155155
}
156156
set adjustment(value: NbAdjustment) {
157-
if (!value) {
158-
// @breaking-change Remove @5.0.0
159-
console.warn(`Falsy values for 'nbPopoverAdjustment' are deprecated and will be removed in Nebular 5.
160-
Use 'noop' instead.`);
161-
value = NbAdjustment.NOOP;
162-
}
163157
this._adjustment = value;
164158
}
165159
protected _adjustment: NbAdjustment = NbAdjustment.CLOCKWISE;

src/framework/theme/components/tooltip/tooltip.directive.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,6 @@ export class NbTooltipDirective implements OnInit, OnChanges, AfterViewInit, OnD
104104
return this._adjustment;
105105
}
106106
set adjustment(value: NbAdjustment) {
107-
if (!value) {
108-
// @breaking-change Remove @5.0.0
109-
console.warn(`Falsy values for 'nbPopoverAdjustment' are deprecated and will be removed in Nebular 5.
110-
Use 'noop' instead.`);
111-
value = NbAdjustment.NOOP;
112-
}
113107
this._adjustment = value;
114108
}
115109
protected _adjustment: NbAdjustment = NbAdjustment.CLOCKWISE;

0 commit comments

Comments
 (0)