chore: update angular to 20 (#3293)

* remove postinstall

* disable husky

* perform base migration to angular 20

* update and enable husky

* update @schematics/angular

* revert postinstall

* remove usage of ComponentFactory and ComponentFactoryResolver

* remove usage of PortalInjector

* remove usage of _COALESCED_STYLE_SCHEDULER and _CoalescedStyleScheduler

* fix eslint usage

* fix pre-commit

* update moment import

* update peerDependencies

* ng update for packages-smoke

* update angular-eslint

* dedupe

* update @types/node, bump angular and nebular for packages-smoke

* fix main.server.ts

* fix server.ts

* update @schematics/angular for packages-smoke

* various fixes

* bump actions/download-artifact

* bump actions/download-artifact

* update nodejs

* fix security hotspots

* update package-lock

Author: Eugeno

.github/workflows/deploy-docs.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.19.5
           cache: 'npm'
       - run: npm ci
       - run: npm run docs:gh-pages

.github/workflows/pr-check.yml

@@ -11,11 +11,11 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.19.5
           cache: 'npm'
       - run: npm ci
       - run: npm run build:packages
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: built-packages
           path: 'dist/'
@@ -27,7 +27,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.19.5
           cache: 'npm'
       - run: |
           npm ci
@@ -40,7 +40,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.19.5
       - run: npm ci
       - run: npm run docs:build
   build-playground:
@@ -50,9 +50,9 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.19.5
       - run: npm ci
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: built-packages
           path: dist
@@ -104,40 +104,40 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.19.5
       - run: npm ci
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: built-packages
           path: dist
       - name: BrowserStack Setup
-        uses: 'browserstack/github-actions@master'
+        uses: 'browserstack/github-actions@93aebce225b754566349151c0676b26b005e591b'
         with:
           username: ${{ env.BSU }}
           access-key: ${{ env.BSK }}
       - name: Start BrowserStackLocal Tunnel
-        uses: browserstack/github-actions/setup-local@master
+        uses: browserstack/github-actions/setup-local@93aebce225b754566349151c0676b26b005e591b
         with:
           local-testing: start
       - name: Test packages
         run: npm run test playground -- -c=production-wp --watch=false
       - name: Test schematics
         run: npm run test:schematics
       - name: Stop BrowserStackLocal Tunnel
-        uses: browserstack/github-actions/setup-local@master
+        uses: browserstack/github-actions/setup-local@93aebce225b754566349151c0676b26b005e591b
         with:
           local-testing: stop
       - name: Upload coverage to codecov
-        uses: codecov/codecov-action@v2
+        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7
   packages-smoke:
     needs: build-packages
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
-      - uses: actions/download-artifact@v2
+          node-version: 20.19.5
+      - uses: actions/download-artifact@v4
         with:
           name: built-packages
           path: packages-smoke/.lib/

.husky/.gitignore

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
-npx lint-staged
+npm run lint:fix

.husky/pre-commit

@@ -1 +1 @@
-18.19.1
+20.19.5

.nvmrc

@@ -20,20 +20,22 @@
       "prefix": "npg",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
-            "outputPath": "dist/playground",
+            "outputPath": {
+              "base": "dist/playground"
+            },
             "index": "src/index.html",
-            "main": "src/main.ts",
-            "polyfills": "src/polyfills.ts",
+            "polyfills": ["src/polyfills.ts"],
             "tsConfig": "src/tsconfig.app.json",
             "inlineStyleLanguage": "scss",
             "assets": [
               "src/favicon.ico",
               "src/assets"
             ],
             "styles": [],
-            "scripts": []
+            "scripts": [],
+            "browser": "src/main.ts"
           },
           "configurations": {
             "production": {
@@ -76,9 +78,7 @@
               "outputHashing": "all"
             },
             "development": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
               "sourceMap": true,
               "namedChunks": true
@@ -127,15 +127,6 @@
               "tsConfig": "src/tsconfig.spec-wp.json"
             }
           }
-        },
-        "lint": {
-          "builder": "@angular-eslint/builder:lint",
-          "options": {
-            "lintFilePatterns": [
-              "src/**/*.ts",
-              "src/**/*.html"
-            ]
-          }
         }
       }
     },
@@ -184,12 +175,13 @@
       "prefix": "ngd",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
-            "outputPath": "dist/docs",
+            "outputPath": {
+              "base": "dist/docs"
+            },
             "index": "docs/index.html",
-            "main": "docs/main.ts",
-            "polyfills": "docs/polyfills.ts",
+            "polyfills": ["docs/polyfills.ts"],
             "tsConfig": "docs/tsconfig.app.json",
             "inlineStyleLanguage": "scss",
             "assets": [
@@ -222,7 +214,8 @@
             ],
             "allowedCommonJsDependencies": [
               "highlight.js"
-            ]
+            ],
+            "browser": "docs/main.ts"
           },
           "configurations": {
             "production": {
@@ -245,9 +238,7 @@
               "outputHashing": "all"
             },
             "development": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
               "sourceMap": true,
               "namedChunks": true
@@ -609,7 +600,8 @@
   "schematics": {
     "@schematics/angular:component": {
       "style": "scss",
-      "changeDetection": "OnPush"
+      "changeDetection": "OnPush",
+      "type": "component"
     },
     "@schematics/angular:application": {
       "strict": true
@@ -619,6 +611,27 @@
     },
     "@angular-eslint/schematics:library": {
       "setParserOptionsProject": true
+    },
+    "@schematics/angular:directive": {
+      "type": "directive"
+    },
+    "@schematics/angular:service": {
+      "type": "service"
+    },
+    "@schematics/angular:guard": {
+      "typeSeparator": "."
+    },
+    "@schematics/angular:interceptor": {
+      "typeSeparator": "."
+    },
+    "@schematics/angular:module": {
+      "typeSeparator": "."
+    },
+    "@schematics/angular:pipe": {
+      "typeSeparator": "."
+    },
+    "@schematics/angular:resolver": {
+      "typeSeparator": "."
     }
   },
   "cli": {

angular.json

@@ -1,9 +1,10 @@
-import rxjs from "eslint-plugin-rxjs";
+import rxjs from "eslint-plugin-rxjs-x";
 import globals from "globals";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import js from "@eslint/js";
 import { FlatCompat } from "@eslint/eslintrc";
+import tseslint from "@typescript-eslint/eslint-plugin";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -16,9 +17,6 @@ const compat = new FlatCompat({
 export default [{
     ignores: [
         "src/framework/**/*",
-        "docs/**/*",
-        "packages-smoke/**/*",
-        "tools/dev-schematics/*/files",
     ],
 }, ...compat.extends(
     "plugin:@angular-eslint/recommended",
@@ -32,6 +30,7 @@ export default [{
 
     plugins: {
         rxjs,
+        "@typescript-eslint": tseslint,
     },
 
     languageOptions: {
@@ -53,6 +52,8 @@ export default [{
         "@typescript-eslint/no-shadow": "error",
         "no-underscore-dangle": "off",
         "@typescript-eslint/consistent-type-definitions": "error",
+        "@angular-eslint/prefer-standalone": "off",
+        "@angular-eslint/prefer-inject": "off",
 
         "rxjs/no-unsafe-takeuntil": ["error", {
             allow: [
@@ -97,4 +98,4 @@ export default [{
         ecmaVersion: 11,
         sourceType: "commonjs",
     },
-}];
+}];