Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tree-grid): allow specify getters for node properties #1254

Merged
merged 7 commits into from
Feb 22, 2019
Merged

refactor(tree-grid): allow specify getters for node properties #1254

merged 7 commits into from
Feb 22, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Feb 21, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Custom getters for node properties

@yggg yggg requested review from nnixaa and Tibing February 21, 2019 14:13
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #1254 into master will increase coverage by 0.02%.
The diff coverage is 90.24%.

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   79.47%   79.49%   +0.02%     
==========================================
  Files         232      232              
  Lines        7020     7024       +4     
  Branches      587      587              
==========================================
+ Hits         5579     5584       +5     
  Misses       1272     1272              
+ Partials      169      168       -1
Impacted Files Coverage Δ
...ponents/tree-grid/data-source/tree-grid.service.ts 62.5% <0%> (ø) ⬆️
.../tree-grid/data-source/tree-grid-filter.service.ts 26.08% <0%> (ø) ⬆️
...omponents/tree-grid/data-source/tree-grid.model.ts 100% <100%> (+7.69%) ⬆️
...e/components/tree-grid/tree-grid-cell.component.ts 68% <100%> (ø) ⬆️
.../theme/components/tree-grid/tree-grid.component.ts 75% <100%> (ø) ⬆️
...ts/tree-grid/data-source/tree-grid-data.service.ts 100% <100%> (ø) ⬆️
...nts/tree-grid/data-source/tree-grid-data-source.ts 86.11% <81.81%> (+0.19%) ⬆️

@yggg yggg requested a review from Tibing February 22, 2019 14:20
@yggg yggg requested review from Tibing and removed request for nnixaa February 22, 2019 15:08
@yggg yggg requested a review from nnixaa February 22, 2019 15:44
@yggg yggg merged commit a263a2e into akveo:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants