Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): emit array when resetting multiple select #1399

Merged
merged 2 commits into from
Apr 22, 2019
Merged

fix(select): emit array when resetting multiple select #1399

merged 2 commits into from
Apr 22, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 19, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Reset emitted null as a select value for multiple select which caused Can't assign a single value if select is marked as multiple error when trying to set null value back (two-way data binding).

@yggg yggg requested a review from nnixaa April 19, 2019 16:34
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #1399 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1399   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files         232      232           
  Lines        7067     7067           
  Branches      600      601    +1     
=======================================
  Hits         5784     5784           
  Misses       1104     1104           
  Partials      179      179
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 90.16% <100%> (ø) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants