Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): add week number column #1963

Merged
merged 14 commits into from
Sep 20, 2019
Merged

feat(calendar): add week number column #1963

merged 14 commits into from
Sep 20, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Sep 19, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg requested a review from nnixaa September 19, 2019 10:01
@yggg yggg requested review from Tibing and removed request for nnixaa September 19, 2019 12:47
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #1963 into master will decrease coverage by <.01%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   84.09%   84.08%   -0.01%     
==========================================
  Files         234      235       +1     
  Lines        7735     7793      +58     
  Branches      680      681       +1     
==========================================
+ Hits         6505     6553      +48     
- Misses       1032     1041       +9     
- Partials      198      199       +1
Impacted Files Coverage Δ
...e/components/calendar-kit/services/date.service.ts 92.3% <ø> (ø) ⬆️
...vigation/calendar-pageable-navigation.component.ts 92.3% <ø> (ø) ⬆️
...eme/components/calendar/base-calendar.component.ts 79.24% <100%> (+2.64%) ⬆️
...me/components/calendar/calendar-range.component.ts 89.09% <100%> (+1.33%) ⬆️
...eme/components/calendar-kit/calendar-kit.module.ts 100% <100%> (ø) ⬆️
...rk/theme/components/calendar/calendar.component.ts 100% <100%> (ø) ⬆️
...lendar-day-picker/calendar-day-picker.component.ts 100% <100%> (ø) ⬆️
...nents/calendar-kit/services/native-date.service.ts 97.22% <50%> (-1.35%) ⬇️
...c/framework/moment/services/moment-date.service.ts 92% <50%> (-1.16%) ⬇️
...amework/date-fns/services/date-fns-date.service.ts 73.07% <60%> (-3.12%) ⬇️
... and 3 more

@yggg yggg merged commit 28e7468 into akveo:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants