Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): add angular positions classes #2048

Merged
merged 4 commits into from
Oct 30, 2019
Merged

fix(tooltip): add angular positions classes #2048

merged 4 commits into from
Oct 30, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Oct 30, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Also fixes positions order for components with preferred physical position (left and right).

Physical positions should be mapped to logical as adjustments use
logical positions.
@yggg yggg requested a review from nnixaa October 30, 2019 07:09
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #2048 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   84.25%   84.28%   +0.03%     
==========================================
  Files         235      235              
  Lines        7899     7905       +6     
  Branches      693      695       +2     
==========================================
+ Hits         6655     6663       +8     
+ Misses       1040     1039       -1     
+ Partials      204      203       -1
Impacted Files Coverage Δ
...k/theme/components/cdk/overlay/overlay-position.ts 93.96% <100%> (+2.14%) ⬆️

@yggg yggg merged commit a15c81d into akveo:master Oct 30, 2019
@yggg yggg deleted the fix/tooltip-add-classes-for-angular-positions branch October 30, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants