-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(badge): dot mode #2479
Merged
Merged
feat(badge): dot mode #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Congratulations 🎉. DeepCode analyzed your code in 2.534 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 253 253
Lines 7759 7770 +11
Branches 852 852
=======================================
+ Hits 6125 6134 +9
- Misses 1369 1371 +2
Partials 265 265
|
yggg
suggested changes
Sep 1, 2020
maksim-karatkevich
force-pushed
the
feat/badge-enhancements
branch
from
September 7, 2020 11:36
64aafa3
to
84be735
Compare
yggg
suggested changes
Sep 10, 2020
src/framework/theme/components/actions/_actions.component.theme.scss
Outdated
Show resolved
Hide resolved
src/framework/theme/components/badge/_badge.component.theme.scss
Outdated
Show resolved
Hide resolved
src/playground/with-layout/action/action-dot-mode.component.html
Outdated
Show resolved
Hide resolved
yggg
suggested changes
Sep 10, 2020
src/framework/theme/components/tabset/_tabset.component.theme.scss
Outdated
Show resolved
Hide resolved
yggg
suggested changes
Sep 10, 2020
src/framework/theme/components/actions/_actions.component.theme.scss
Outdated
Show resolved
Hide resolved
yggg
changed the title
fix(badge-enhancements): add action badge and dote mode
fix(badge enhancements): add action badge and dote mode
Sep 11, 2020
yggg
changed the title
fix(badge enhancements): add action badge and dote mode
feat(badge): dot mode
Sep 16, 2020
yggg
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Adds dot mode to the badge. Also, adds badge for menu items.