fix(menu): avoid DOM elements creation for hidden menu items (fix#270) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mishkolesnikov let's add a test for this case also |
mishkolesnikov
force-pushed
the
feature/menu-fix
branch
from
9ac68e9
to
e0bfe5f
Compare
nnixaa
previously approved these changes
Mar 27, 2018
|
@mishkolesnikov could you check the conflicts? |
mishkolesnikov
force-pushed
the
feature/menu-fix
branch
from
8cf7393
to
6769b85
Compare
nnixaa
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #270