Skip to content

Conversation

KimPark89
Copy link
Contributor

Fixes goToDate bug that causes that the calendar sometimes goes to 1
day before the chosen date

Fixes goToDate bug that causes that the calendar sometimes goes to 1
day before the chosen date
@alamkanak
Copy link
Owner

So it was a time zone issue then!
@caske33 Did you happen to test this out?

@entropitor
Copy link
Contributor

I've tested my version 94230c5 which does the division before the subtraction because I think there was a bug there too. (I'm not sure in which branch I commited that, but it's there in my fork).

I'm not sure if it solves a bug (I don't know how to recreate the bug). but it at least doesn't create one. And I can scroll one day at a time for over 3 months without a problem...

@alamkanak
Copy link
Owner

@KimPark89 Can you provide a way to reproduce the bug in the current version of the lib? Need to test it before I merge.

@KimPark89
Copy link
Contributor Author

@alamkanak Very easy. Actually we are in "daylight saving time" so you just need to go to a date in the past in "standard time" to reproduce the bug. For example go to 20 March 2015. The destination will be 21 March 2015.

@alamkanak alamkanak merged commit 89a126e into alamkanak:master May 9, 2015
BoxResin pushed a commit to BoxResin/Android-Week-View that referenced this pull request Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants