Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to module 5: Testing your Code #147

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

andrewphilipsmith
Copy link
Contributor

This PR implements some of the changes recommended in #88 and #131.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jemrobinson
Copy link
Member

Is there anything else you want to include in this PR @andrewphilipsmith or is it ready to review?

@andrewphilipsmith andrewphilipsmith marked this pull request as draft November 3, 2022 10:41
@andrewphilipsmith
Copy link
Contributor Author

Is there anything else you want to include in this PR @andrewphilipsmith or is it ready to review?

No, not yet. I've switched it to draft.

@andrewphilipsmith andrewphilipsmith marked this pull request as ready for review November 3, 2022 16:31
@andrewphilipsmith
Copy link
Contributor Author

I think that this can be merged. I will create a separate PR to look at the final example.

Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when you're ready.

@andrewphilipsmith andrewphilipsmith merged commit 2ec34c5 into main Nov 3, 2022
@andrewphilipsmith andrewphilipsmith deleted the update/module05 branch November 3, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants