Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the thumbnail Width and Height settings in album #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcdietrich
Copy link

No description provided.

@alangrainger
Copy link
Owner

Hi @jcdietrich - sorry it's taken me so long to reply to this. I'm not much of a developer so receiving a Pull Request is still something new to me.

I appreciate the PR, but consider the case where someone wants high-resolution locally saved images. They would set their thumbnail size to be say 1000x1000, and then the grid view would be unusable.

We could add a new setting into the Settings page for the grid view thumbnail size, but you could simply target the .google-photos-grid-thumbnail class in your vault CSS if you want?

@emotionalemf
Copy link

Hello @alangrainger, I tried changing the css to get larger thumbnail size, but now they look pixelated and low quality renders.

Is this the correct css? Do I have to do something else?

.google-photos-grid-thumbnail {
  height: 600px;
}

I would suggest adding a separate setting for thumbnail sizes in codeblock output.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants